Repository navigation
1.45.0: Tank Sim shows the gear to wear, with trinket and ring pairs and a live weight - #60
Merged
Merged
Conversation
…and a live weight After the gear search, the best trinkets and rings are simulated as pairs together with the two worn, since one trinket measured alone cannot say whether to wear 1+2 or 1+4. The result opens with "Gear to wear" for each fight: the best measured item in every slot (upgrade level and crest cost for crest upgrades, source and item level for drops and bags) and the best pair of trinkets and of rings. A ranking weight slider ranks again at once, because each result keeps its DPS and survival gains and both errors; the page warns when the slider is far from the weight the final round was chosen with. Each slot is measured on its own against the worn gear, so it is not one combined set, and the page says so. Tested on a Guardian Druid through the app (pairs of trinkets and rings in both fights, the recommendation changing between 0, 50 and 100% survival) and with a unit test of the pairs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a pair round for trinkets and rings (every pair with the two worn, simulated together) and a Gear to wear view per fight with a ranking-weight slider that re-ranks without a new simulation.
Not one combined set: each slot is measured alone against worn gear, and the page says so (the Best in Slot idea was removed in 1.40.0 for that reason).
Tested: npm test (244 pass); tests/tank-gear-integration.mjs on a live server; the page in the app.
🤖 Generated with Claude Code